From b255a8cd902cbacd7af55856219655dc8749053c Mon Sep 17 00:00:00 2001
From: Gregory Soutade <gregory@soutade.fr>
Date: Sat, 5 Sep 2015 09:21:45 +0200
Subject: [PATCH] Display an error message when a query failed (previous :
 silent fail...)

---
 server/functions.php | 34 +++++++++++++++++++++++++---------
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git a/server/functions.php b/server/functions.php
index 3612e08..e205fb4 100755
--- a/server/functions.php
+++ b/server/functions.php
@@ -169,13 +169,20 @@ function add_entry($user, $login, $password,
     $result = $db->query("INSERT INTO gpass ('login', 'password', 'shadow_login', 'salt', 'access_token') VALUES
  ('" . $login . "', '" . $password . "', '" . $shadow_login . "', '" . $salt . "', '" . $access_token . "')");
 
-    error_log("INSERT INTO gpass ('login', 'password', 'shadow_login', 'salt', 'access_token') VALUES
- ('" . $login . "', '" . $password . "', '" . $shadow_login . "', '" . $salt . "', '" . $access_token . "')");
+ /*    error_log("INSERT INTO gpass ('login', 'password', 'shadow_login', 'salt', 'access_token') VALUES */
+ /* ('" . $login . "', '" . $password . "', '" . $shadow_login . "', '" . $salt . "', '" . $access_token . "')"); */
     $db->close();
 
-    echo "OK";
-
-    return true;
+    if ($result == FALSE)
+    {
+        echo "Error " . $db->lastErrorMsg();
+        return false;
+    }
+    else
+    {
+        echo "OK";
+        return true;
+    }
 }
 
 function delete_entry($user, $login, $access_token)
@@ -197,10 +204,19 @@ function delete_entry($user, $login, $access_token)
     }
     else
     {
-        $db->query("DELETE FROM gpass WHERE login='" . $login . "'");
+        $result = $db->query("DELETE FROM gpass WHERE login='" . $login . "'");
         $db->close();
-        echo "OK";
-        return true;
+
+        if ($result == FALSE)
+        {
+            echo "Error " . $db->lastErrorMsg();
+            return false;
+        }
+        else
+        {
+            echo "OK";
+            return true;
+        }
     }
 }
 
@@ -257,7 +273,7 @@ function get_secure_entries($user, $access_tokens)
     }
     $query .= ")";
 
-    error_log($query);
+    //error_log($query);
     $result = $db->query($query);
 
     header('Content-Type: application/json');