Passes re

src/controller/KissCount.cpp

@@ -36,12 +36,12 @@ std::list<wxString> KissCount::GetUsers()
   return _db->GetUsers();
 }
 
-bool KissCount::IsValidUser(wxString user, wxString password)
+bool KissCount::IsValidUser(const wxString& user, const wxString& password)
 {
   return _db->IsValidUser(user, password) ;
 }
 
-void KissCount::LoadUser(wxString user)
+void KissCount::LoadUser(const wxString& user)
 {
   if (_user) delete _user;
   _user = _db->LoadUser(user) ;
@@ -66,22 +66,22 @@ User* KissCount::GetUser()
   return _user;
 }
 
-double KissCount::GetAccountAmount(wxString id, int month, int year)
+double KissCount::GetAccountAmount(const wxString& id, int month, int year)
 {
   return _db->GetAccountAmount(id, month, year);
 }
 
-void KissCount::UpdateOperation(Operation op)
+void KissCount::UpdateOperation(Operation& op)
 {
   _db->UpdateOperation(op);
 }
 
-wxString KissCount::AddOperation(Operation op)
+wxString KissCount::AddOperation(Operation& op)
 {
   return _db->AddOperation(_user, op);
 }
 
-void KissCount::DeleteOperation(Operation op)
+void KissCount::DeleteOperation(Operation& op)
 {
   _db->DeleteOperation(op);
 }
@@ -99,12 +99,12 @@ void KissCount::DeleteOperations(int month, int year)
     }
 }
 
-void KissCount::SetAccountAmount(int month, int year, wxString accountId, double amount)
+void KissCount::SetAccountAmount(int month, int year, const wxString& accountId, double amount)
 {
   _db->SetAccountAmount(month, year, accountId, amount);
 }
 
-wxString KissCount::AddAccount(Account ac)
+wxString KissCount::AddAccount(Account& ac)
 {
   ac.id = _db->AddAccount(_user, ac);
   _user->_accounts.push_back(ac);
@@ -112,7 +112,7 @@ wxString KissCount::AddAccount(Account ac)
   return ac.id;
 }
 
-void KissCount::UpdateAccount(Account ac)
+void KissCount::UpdateAccount(Account& ac)
 {
   std::vector<Account>::iterator it;
   int i;
@@ -123,7 +123,7 @@ void KissCount::UpdateAccount(Account ac)
       _user->_accounts[i] = ac;
 }
 
-void KissCount::DeleteAccount(Account ac)
+void KissCount::DeleteAccount(Account& ac)
 {
   std::vector<Account>::iterator it;
   int i;
@@ -137,7 +137,7 @@ void KissCount::DeleteAccount(Account ac)
       }
 }
 
-wxString KissCount::AddCategory(Category category)
+wxString KissCount::AddCategory(Category& category)
 {
   wxString id;
   id = _db->AddCategory(_user, category);
@@ -148,7 +148,7 @@ wxString KissCount::AddCategory(Category category)
   return id;
 }
 
-void KissCount::UpdateCategory(Category category)
+void KissCount::UpdateCategory(Category& category)
 {
   _db->UpdateCategory(category);
   
@@ -160,7 +160,7 @@ void KissCount::UpdateCategory(Category category)
       }
 }
 
-void KissCount::DeleteCategory(Category category)
+void KissCount::DeleteCategory(Category& category)
 {
   _db->DeleteCategory(_user, category);
 
@@ -206,23 +206,23 @@ void KissCount::GenerateMonth(int monthFrom, int yearFrom, int monthTo, int year
   _wxUI->GenerateMonth(monthTo, yearTo);
 }
 
-void KissCount::ChangePassword(wxString password)
+void KissCount::ChangePassword(const wxString& password)
 {
   _db->ChangePassword(_user, password);
 }
 
-bool KissCount::UserExists(wxString name)
+bool KissCount::UserExists(const wxString& name)
 {
   return _db->UserExists(name);
 }
 
-void KissCount::ChangeName(wxString name)
+void KissCount::ChangeName(const wxString& name)
 {
   _db->ChangeName(_user, name);
   _user->_name = name;
 }
 
-void KissCount::NewUser(wxString name)
+void KissCount::NewUser(const wxString& name)
 {
   wxDateTime curDate;
   Account ac = {wxT(""), wxT("Account 1"), wxT(""), false, true};

src/controller/KissCount.h

@@ -16,30 +16,30 @@ class KissCount
   ~KissCount();
 
   std::list<wxString> GetUsers();
-  bool IsValidUser(wxString user, wxString password);
-  void LoadUser(wxString user);
+  bool IsValidUser(const wxString& user, const wxString& password);
+  void LoadUser(const wxString& user);
   User* GetUser();
-  void ChangePassword(wxString password);
-  bool UserExists(wxString name);
-  void ChangeName(wxString name);
-  void NewUser(wxString name);
+  void ChangePassword(const wxString& password);
+  bool UserExists(const wxString& name);
+  void ChangeName(const wxString& name);
+  void NewUser(const wxString& name);
 
   void LoadYear(int year, bool force=false);
 
-  wxString AddOperation(Operation op);
-  void UpdateOperation(Operation op);
-  void DeleteOperation(Operation op);
+  wxString AddOperation(Operation& op);
+  void UpdateOperation(Operation& op);
+  void DeleteOperation(Operation& op);
   void DeleteOperations(int month, int year);
 
-  double GetAccountAmount(wxString id, int month, int year);
-  void SetAccountAmount(int month, int year, wxString accountId, double value);
-  wxString AddAccount(Account ac);
-  void UpdateAccount(Account ac);
-  void DeleteAccount(Account ac);
+  double GetAccountAmount(const wxString& id, int month, int year);
+  void SetAccountAmount(int month, int year, const wxString& accountId, double value);
+  wxString AddAccount(Account& ac);
+  void UpdateAccount(Account& ac);
+  void DeleteAccount(Account& ac);
 
-  wxString AddCategory(Category category);
-  void UpdateCategory(Category category);
-  void DeleteCategory(Category category);
+  wxString AddCategory(Category& category);
+  void UpdateCategory(Category& category);
+  void DeleteCategory(Category& category);
 
   std::map<int, std::vector<int> > GetAllOperations();